Added support for lacking content-disposition and lacking filename#3
Added support for lacking content-disposition and lacking filename#3tmfksoft wants to merge 1 commit intofreesoftwarefactory:masterfrom
Conversation
|
NOTICE REGARDING CHANGING THE RETURNED DATA I've also updated the README to reflect the changes. I ended up changing the format of the files to suit following spec where "name" is used to refer to files uploaded via a HTTP Form. The data returned is no longer an array of files and is instead an object. The object keys will be the "name" of each file. Here's an example of what to expect: {
avatar: {
type: 'image/png',
filename: 'avatar.png',
name: 'avatar',
data: <Buffer 00 00 00>
}
}If you recieve multiple avatars: {
avatar: [
{
type: 'image/png',
filename: 'avatar.png',
name: 'avatar',
data: <Buffer 00 00 00>
},
{
type: 'image/png',
filename: 'avatar.png',
name: 'avatar',
data: <Buffer 00 00 00>
},
]
} |
|
yes you're right. The process() function should be customized, will test in
my side using your payload, also will check your PR soon,
thanku:)
2017-05-25 0:19 GMT-04:00 Thomas Edwards <notifications@github.com>:
… I've also updated the README to reflect the changes. I ended up changing
the format of the files to suit following spec where "name" is used to
refer to files uploaded via a HTTP Form.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABk4g3-Wmf4vgc9ZFIRBYJriIpLWGUZ5ks5r9QFvgaJpZM4Nl8ff>
.
--
*Cristian A. Salazar *
*Building Next Generation Apps with Serverless/Microservices, follow me:
@AmazonAwsVideos*
(+569) 9649-3840 | https://plus.google.com/+ChristianSalazar
Santiago. Chile.
Bitbucket <https://bitbucket.org/christiansalazarh/> | Github
<https://github.com/freesoftwarefactory> | Stackoverflow
<http://stackoverflow.com/users/937815/christian> | Google +
<https://plus.google.com/+ChristianSalazar> | Blog
<http://trucosdeprogramacionmovil.blogspot.cl/> | Youtube
<http://www.youtube.com/c/ChristianSalazar> | Npm (NodeJs)
<https://www.npmjs.com/~csalazar>
|
|
No problem :) |
|
Hi there :) is possible for you to paste here a sample payload exposing this case ? |
This PR rewrites the process function.
In the PR I've added support for lacking Content-Disposition as per a multipart/related request where it isn't mandatory.
Added support for lacking filename which also isn't mandatory.
Feel free to use any of the code in the PR.
It should be pretty easy to expand on my code to add support for different headers.
The code was tested with Amazon AWS V1 Speech Recognition.
An example payload from Amazon AWS V1:
http://haste.thomas-edwards.me/usitucezad.txt
Note the lack of Content-Disposition.
One last addition,
A requests entire headers object and now be supplied to getBoundary and it'll try and extract content-type. Although will work fine as it did originally.