Skip to content

Fix [0,0,0] "bullet hole" artefact in spherical barycentric resampling #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnolan14 merged 1 commit into from
May 22, 2026
Merged

Fix [0,0,0] "bullet hole" artefact in spherical barycentric resampling #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions surfa/mesh/sphere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def spherical_to_cartesian(points):
return np.stack([x, y, z], axis=1)


def barycentric_spherical_map(source, target, neighborhood=10):
def barycentric_spherical_map(source, target, neighborhood=30):
"""
Map the points of a target sphere to the barycentric coordinates of the nearest
triangle on a source sphere.
Expand All @@ -125,7 +125,7 @@ def barycentric_spherical_map(source, target, neighborhood=10):
target : Mesh
Target sphere mesh.
neighborhood : int, optional
Max number of nearest triangles to consider for each target point.
Max number of nearest triangles to consider for each target point.

Returns
-------
Expand Down Expand Up @@ -214,12 +214,12 @@ def barycentric_spherical_map(source, target, neighborhood=10):
intersecting_faces[remaining] = faces[hits]
intersecting_barycenters[remaining] = barycentric[hits]

# if any target points were not assigned a face, just assign them the
# center of the nearest face
if np.count_nonzero(remaining) != 0:
missing = intersecting_faces == -1
# If any target points were not assigned a face,
# fall back to the nearest face (barycentric centroid).
missing = intersecting_faces == -1
if np.count_nonzero(missing) != 0:
intersecting_faces[missing] = nearest[0][missing]
intersecting_barycenters[missing] = 0.33333333
intersecting_barycenters[missing] = 1.0 / 3.0

return intersecting_faces, intersecting_barycenters

Expand Down
Loading