NumPy 2.x compatibility fixes for image interpolation and I/O#78
Merged
Conversation
Resolve interp.pyx byteorder conflict with native dtype view
Prefer dtype.newbyteorder('=') after byteswap() because the intended
post-conversion invariant is native-endian data. The no-argument form would
also work in this guarded block, but the explicit native byte order better
documents the intent and is less dependent on the surrounding condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Surfa for NumPy 2.x compatibility while preserving NumPy 1.x behavior.
Changes include:
byteswap().view(dtype.newbyteorder('='))path.SURFA_ABI3=1package_dataso both.pyxand.hfiles are included.Testing
Added
test/test_numpy_compat.pycovering native vs non-native endian resize behavior.