Skip to content

Eliminate unused variables in PdfRenderer.draw() #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmjcode merged 1 commit into from
May 12, 2026
Merged

Eliminate unused variables in PdfRenderer.draw() #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions qpageview/pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,6 @@ def draw(self, page, painter, key, tile, paperColor=None):

doc = page.document
num = page.pageNumber
xres = painter.device().logicalDpiX()
yres = painter.device().logicalDpiY()

# We use this to scale from key/tile to device coordinates
matrix = painter.deviceTransform()
Expand All @@ -257,22 +255,20 @@ def draw(self, page, painter, key, tile, paperColor=None):
# are "actual size" and scaling is our responsibility. When printing,
# the painter coordinates are scaled to the device's resolution and
# scaling is the device's responsibility.
vscale = matrix.m11()
hscale = matrix.m22()
actualSize = (vscale == hscale == 1)
# Note: m11 and m22 are our horizontal and vertical scaling factors.
actualSize = (matrix.m11() == matrix.m22() == 1)

# Oversampling produces more readable output at lower resolutions
# when painting at "actual size"
if actualSize:
# If our effective pixel density at this zoom level is below
# our threshold, render at double size then downscale
xresEffective = 72.0 * key.width / pageSize.width()
yresEffective = 72.0 * key.height / pageSize.height()
xMultiplier = 2 if xresEffective < self.oversampleThreshold else 1
yMultiplier = 2 if yresEffective < self.oversampleThreshold else 1
xres = 72.0 * key.width / pageSize.width()
yres = 72.0 * key.height / pageSize.height()
xMultiplier = 2 if xres < self.oversampleThreshold else 1
yMultiplier = 2 if yres < self.oversampleThreshold else 1
else:
xMultiplier = 1
yMultiplier = 1
xMultiplier = yMultiplier = 1

# Set rendering options
RenderFlag = QPdfDocumentRenderOptions.RenderFlag
Expand Down
Loading