Fix copy of "language-xxx" class from code tag to pre tag#63
Open
tholst wants to merge 1 commit intofrontarm:masterfrom
Open
Fix copy of "language-xxx" class from code tag to pre tag#63tholst wants to merge 1 commit intofrontarm:masterfrom
tholst wants to merge 1 commit intofrontarm:masterfrom
Conversation
|
nice, this is also an issue for me. I found a template that uses mdx-loader. Looks like they used some css for the doing something like this for now: where and note the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Note: I created a new PR which is the same as #58 but without the change to Readme as I saw now that my assumption wrt. rehype-prism was wrong.
Original Message
I was using your mdx-loader package (Thanks!) and found that prisjms-highlighted code did not receive any background styling due to missing language-xxx classes on the pre tags. As you pointed out in your code comments, prismjs expects those language classes on the pre tags.
Also you are not using rehype-prism as far as I can see. So I took the liberty of removing it from the README.Cheers