Updated .gitignore and added .editorconfig with Fantomas settings#727
Updated .gitignore and added .editorconfig with Fantomas settings#727xperiandri wants to merge 1 commit intomasterfrom
.gitignore and added .editorconfig with Fantomas settings#727Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances project configuration by standardizing tool usage and formatting setups.
- Introduces a Directory.Build.targets file with targets for updating, restoring, and formatting dotnet tools (including Fantomas).
- Updates CHANGELOG.md with entries for the new .gitignore and .editorconfig files.
- Adds supporting configuration files (.gitattributes, .git-blame-ignore-revs, .fantomasignore, .editorconfig, and .config/dotnet-tools.json) to enforce consistent formatting and tool behavior.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.targets | Adds targets to update, restore, and run dotnet tools including Fantomas. |
| CHANGELOG.md | Updates changelog entries reflecting modifications to gitignore and editorconfig. |
| .gitattributes | Adds settings for VB and shell files. |
| .git-blame-ignore-revs | Establishes commits to ignore (e.g., formatting changes). |
| .fantomasignore | Adds ignore settings for AssemblyInfo files to be skipped by Fantomas. |
| .editorconfig | Provides a comprehensive set of formatting rules including Fantomas settings. |
| .config/dotnet-tools.json | Updates tool configurations with explicit tool versions and rollForward settings. |
| <_BuildProjBaseIntermediateOutputPath>$(MSBuildThisFileDirectory)build/obj/</_BuildProjBaseIntermediateOutputPath> | ||
| <_DotnetToolManifestFile>$(MSBuildThisFileDirectory).config/dotnet-tools.json</_DotnetToolManifestFile> | ||
| <_DotnetToolRestoreOutputFile>$(_BuildProjBaseIntermediateOutputPath)/dotnet-tool-restore-$(NETCoreSdkVersion)-$(OS)</_DotnetToolRestoreOutputFile> | ||
| <_DotnetFantomasOutputFile>$(BaseIntermediateOutputPath)dotnet-fantomas-msbuild-$(NETCoreSdkVersion)-$(OS)</_DotnetFantomasOutputFile> |
There was a problem hiding this comment.
Consider using the already defined property
| <_DotnetFantomasOutputFile>$(BaseIntermediateOutputPath)dotnet-fantomas-msbuild-$(NETCoreSdkVersion)-$(OS)</_DotnetFantomasOutputFile> | |
| <_DotnetFantomasOutputFile>$(_BuildProjBaseIntermediateOutputPath)dotnet-fantomas-msbuild-$(NETCoreSdkVersion)-$(OS)</_DotnetFantomasOutputFile> |
65a419a to
591900c
Compare
|
@knocte I have not tried to align the Fantomas setup to the repo style. If you have any preferences, please comment. |
I actually prefer whole repo formatting, however, I was holding off doing fantomas myself because I knew that doing it right now would make a bunch of PRs have conflicts; and not just straightforward conflicts, but conflicts very annoying to resolve. Therefore I would be inclined to work on this only after we have merged a bunch of PRs that are pending (yes the DRAFT ones also count, we plan to revisit those soon). |
.editorconfig(my setup, I have not tried to align with the repo style)