DRAFT: Consolidate error/warning/suggestion terms into violation/failure#793
Open
knocte wants to merge 2 commits intofsprojects:masterfrom
Open
DRAFT: Consolidate error/warning/suggestion terms into violation/failure#793knocte wants to merge 2 commits intofsprojects:masterfrom
knocte wants to merge 2 commits intofsprojects:masterfrom
Conversation
knocte
force-pushed
the
wip/streamlineTerminology
branch
2 times, most recently
from
e4f9bbb to
e110054
Compare
When using FSharpLint it's usual to refer to the reports that the rules generate as "errors" or "warnings" or "suggestions", and the first two are easily confused with compiler errors/warnings if not careful. Using so many different terms is also confusing so with this commit we will from now on call them "violations". Note, however, that some instances of "error" have been replaced with "failures" instead of "violations" if they refer to exceptions or other bugs/issues that FSharpLint might generate when not working properly.
knocte
force-pushed
the
wip/streamlineTerminology
branch
4 times, most recently
from
d715f96 to
ffdb03f
Compare
knocte
force-pushed
the
wip/streamlineTerminology
branch
from
ffdb03f to
db26f1b
Compare
Across the codebase, there were two different ways to name the same thing: quickFix or suggestedFix. From now on we will call it AutoFix and streamline all occurrences into this same term.
knocte
force-pushed
the
wip/streamlineTerminology
branch
from
db26f1b to
01b6c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using FSharpLint it's usual to refer to the reports that the rules generate as "errors" or "warnings" or "suggestions", and the first two are easily confused with compiler errors/warnings if not careful. Using so many different terms is also confusing so with this commit we will from now on call them "violations". Note, however, that some instances of "error" have been replaced with "failures" instead of "violations" if they refer to exceptions or other bugs/issues that FSharpLint might generate when not working properly.