Console: process multiple targets

[webwarrior-ws]

All supplied targets are processed (instead of only the last one, as it was before), but only if the --file-type is given or inferred type is the same for all targets. Otherwise there will be an error.

Fixes #802

[knocte]

One last thing to test here before I merge: make sure inline-source linting didn't get broken.

Now, how to test this? I'm actually suspicious that it might be broken already, take a look at issue 801 and you let me know what you think (it also fails for FailWithBadUsage, in case 801 is a real false negative of FL87 rule).

[webwarrior-ws]

One last thing to test here before I merge: make sure inline-source linting didn't get broken.

Now, how to test this? I'm actually suspicious that it might be broken already, take a look at issue 801 and you let me know what you think (it also fails for FailWithBadUsage, in case 801 is a real false negative of FL87 rule).

This is what I get:

dotnet run --framework net8.0 --project .\src\FSharpLint.Console\FSharpLint.Console.fsproj lint sprintf String.Empty
========== Linting <inline source> ==========
========== Finished: 0 warnings ==========
========== Summary: 0 warnings ==========
========== Linting <inline source> ==========
========== Finished: 0 warnings ==========
========== Summary: 0 warnings ==========

Not sure what is the expected output.

[knocte]

Read issue 801 again, it is about FL87 rule. Analyze if that is truly a false negative (with a unit test?); if it is then we can create a PR to fix 801, but then we need another way to test inline source, try failwith String.Empty, which I think should fire https://fsprojects.github.io/FSharpLint/how-tos/rules/FL0072.html , but you can confirm it, again, by looking at its unit tests.

[knocte]

All in all, I'm trying to find the easiest way to test inline source with a source code fragment that takes only one line (like the above examples) but that creates at least one rule violation.

[webwarrior-ws]

dotnet run --framework net8.0 --project .\src\FSharpLint.Console\FSharpLint.Console.fsproj lint 'failwith String.Empty'
========== Linting <inline source> ==========
Bad usage of failwith: consider using a non-empty error message as parameter.
Error on line 1 starting at column 0
failwith String.Empty
^
See https://fsprojects.github.io/FSharpLint/how-tos/rules/FL0072.html
--------------------------------------------------------------------------------
========== Finished: 1 warnings ==========
========== Summary: 1 warnings ==========

So inline-source linting does work.

[knocte]

So inline-source linting always requires wrapping the source with quotes?

[webwarrior-ws]

So inline-source linting always requires wrapping the source with quotes?

Yes, otherwise it will treat it as separate arguments.

[knocte]

Yes, otherwise it will treat it as separate arguments.

Master branch too?

[webwarrior-ws]

Yes, otherwise it will treat it as separate arguments.

Master branch too?

In master only last non-named argument is considered. So e.g. in case of sprintf String.Empty the source that gets checked is String.Empty.