Merged
Conversation
Member
|
Please update from (NM: did it for you :) ) |
Member
|
The set of failing tests, all relying on custom codecs that don't work in zarr 3, could be gated to only run on zarr 2. |
Contributor
Author
|
Should probably add a test where v is a 1D array with a single element. |
Contributor
Author
I'm not sure how to fix that. |
Member
|
OK, don't worry about it. |
|
@martindurant Could you please publish a release with this fix? Thank you so much for your help! |
Member
|
0.2.10 is out |
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a TypeError where int/float/str/bool care called on
vandvis a 1D array of 1 element.Addresses #582