Skip to content

Use bisect for listing deduplication #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martindurant merged 1 commit into from
Feb 18, 2026
+9 −5
Merged

Use bisect for listing deduplication #1010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions s3fs/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import asyncio
import bisect
import errno
import io
import logging
Expand Down Expand Up @@ -1008,11 +1009,14 @@ async def _find(
# Explicitly add directories to their parents in the dircache
for d in dirs:
par = self._parent(d["name"])
# extra condition here (in any()) to deal with directory-marking files
if par in thisdircache and not any(
_["name"] == d["name"] for _ in thisdircache[par]
):
thisdircache[par].append(d)
if par in thisdircache:
# listing is sorted
ind = bisect.bisect_right(
thisdircache[par], d["name"], key=lambda _: _["name"]
)
if thisdircache[par][ind - 1]["name"] != d["name"]:
# name is not already present
thisdircache[par].insert(ind, d)

if not prefix:
for k, v in thisdircache.items():
Expand Down
Loading