Open
Conversation
Move scala-xml related code to separate module
This makes the scalaxml module only available for the JVM because scala-xml is not available for Scala Native and fails with linking errors on Scala.js: ``` Referring to non-existent class javax.xml.parsers.SAXParserFactory$ called from scala.xml.factory.XMLLoader.parser()javax.xml.parsers.SAXParser called from scala.xml.XML$.parser()javax.xml.parsers.SAXParser called from scala.xml.factory.XMLLoader.loadString(java.lang.String)scala.xml.Node called from scala.xml.XML$.loadString(java.lang.String)scala.xml.Node called from eu.timepit.refined.scalaxml.string$Xml$.$$anonfun$xmlValidate$1(java.lang.String)scala.xml.Elem called from eu.timepit.refined.scalaxml.string$Xml$.xmlValidate()eu.timepit.refined.api.Validate ```
Make scalaxml module JVM-only
Merge master into series/0.10
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #713 +/- ##
==========================================
+ Coverage 92.39% 93.28% +0.89%
==========================================
Files 63 65 +2
Lines 815 804 -11
Branches 6 10 +4
==========================================
- Hits 753 750 -3
+ Misses 62 54 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
Before merging, this should happen on the
|
* Remove deprecated generic predicates * Remove deprecated methods in RefType
* Use Int literals for numeric predicates like Positive See #841 (comment). * Replace Nat in MaxSize and NonEmptyFiniteString
Deprecate support for Nat as arguments for predicates
Merge master into series/0.10
Merge master into series/0.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.