Open
Conversation
…ate, renaming and removad of redundant classes.
This directory structure matches that of other open source libraries, and is less cluttered. Important advantages: * The public interface is separated from the private implementation details into the include/ and Implementation/ directories respectively * This public interface has a top-level Fuffr folder so that includes can be done with #include <Fuffr/header.h>, like other iOS libraries. * Examples are separated from the library code proper in Examples/ * A top-level Xcode project for the library is available for easy inclusion in other projects. Documentation is put into its own folder, but this is not a convention or very important, I just found it to be nice to de-clutter the root of the repo.
Author
|
Oops. I based this work on the branch update1, and meant to send the PR to it, and not to master. Ah well, still work-in-progres so it doesn't matter |
|
Hi Nevyn, the new structure looks great! Nice project organisation, much better than what we have now. Lets look into how to merge this. Best, Micke :) |
Author
|
Is there a good timing for when I should do the work, when you have some downtime on ios? it's not gonna be fun to merge if we both do work on different structure... Don't mind redoing it though, as long as it's merged soon after done |
Owner
|
Hi guys, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reorganization makes the repo layout match how I always organize my libraries, and roughly how many third-party libraries (both C, C++ and ObjC) generally organize their repos.
It's a work-in-progress, so don't merge this PR! I haven't fixed any include paths, project files or even figured out what should be public interface and what is implementation detail. I just wanted to let you know that I started this work and what I mean by "better repo layout", and so that you can tell me whether this is something you want done before I spend more time on it. Now I gotta sleep though, so I can't keep working on it tonight :)