fix(#2527): use _CLIENT_ID suffix in variableNameForRole#2532
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#2527): use _CLIENT_ID suffix in variableNameForRole#2532fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The TypeScript port of variableNameForRole in
web/admin/src/lib/layers/secrets.ts generated
FULLSEND_{ROLE}_APP_ID, but the Go backend
(internal/layers/secrets.go:187) uses
FULLSEND_{ROLE}_CLIENT_ID. This mismatch caused
the admin UI to check for the wrong GitHub Actions
variables and report incorrect missing-variable
diagnostics.
Updated the suffix from _APP_ID to _CLIENT_ID and
fixed all test expectations in secrets.test.ts to
match.
Note: pre-commit could not run due to shellcheck
network error (exit 3). Post-script will run it
authoritatively.
Closes #2527
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
Site previewPreview: https://b6628690-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 8:04 PM UTC · Completed 8:11 PM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: Bug fix in web admin secrets layer aligning TypeScript with Go backend naming |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
ifireball
approved these changes
Jun 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript port of variableNameForRole in web/admin/src/lib/layers/secrets.ts generated FULLSEND_{ROLE}APP_ID, but the Go backend (internal/layers/secrets.go:187) uses FULLSEND{ROLE}_CLIENT_ID. This mismatch caused the admin UI to check for the wrong GitHub Actions variables and report incorrect missing-variable diagnostics.
Updated the suffix from _APP_ID to _CLIENT_ID and fixed all test expectations in secrets.test.ts to match.
Note: pre-commit could not run due to shellcheck network error (exit 3). Post-script will run it authoritatively.
Closes #2527
Post-script verification
agent/2527-fix-variable-suffix)0fb80c941536a21bb26c32be3fbe298dcc67d83b..HEAD)