Open
Conversation
dragonsinth
requested changes
Jan 9, 2024
Member
dragonsinth
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution but it's going to be more complicated than what's in this PR. It's actually quite complex to keep things in sync correctly. Notice this doc on the request object:
* There are three representations of the request to keep in sync: (1) the
* raw JSON, (2) the request object, and (3) the form which contains a
* hierarchy of inputs. There are only two ways that the request can be
* modified: by editing the raw JSON or interacting with inputs on the form.
Adding a raw header input would need to be equally sophisticated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'have problem with adding bunch of headers so i pr this raw header