Update README.md and example-config.toml to be more accurate#112
Open
randito78 wants to merge 2 commits intofullstorydev:masterfrom
Open
Update README.md and example-config.toml to be more accurate#112randito78 wants to merge 2 commits intofullstorydev:masterfrom
randito78 wants to merge 2 commits intofullstorydev:masterfrom
Conversation
Update example-config.toml to require StartTime to not mislead those using the example. As of https://github.com/fullstorydev/hauser/pull/95/files StartTime is required or it returns an error such as Error: cannot parse "'2020-09-01T20:41:15Z'" as "".
Collaborator
camphillips22
left a comment
camphillips22
left a comment
There was a problem hiding this comment.
Thank you for the PR! Just one comment, otherwise LGTM.
| # This should be an timestamp like with the followin format: 2018-12-27T18:30:00Z. | ||
| # If start time is empty, this will default to 30 days in the past. | ||
| StartTime = "" | ||
| StartTime = <Start time for data exports in the following format: 2018-12-27T18:30:00Z> |
Collaborator
There was a problem hiding this comment.
Instead of using a value that is definitely not parseable, I would prefer that we use the "zero" time value for go
Suggested change
| StartTime = <Start time for data exports in the following format: 2018-12-27T18:30:00Z> | |
| # If not set or left as the zero time, this will default to 30 days in the past. | |
| # StartTime = "0001-01-01T00:00:00Z" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a note about necessary FullStory API permission levels for the API key as well as change the note for StartTime as it errors with the pre-existing empty string while casting to time with the error
Error: cannot parse "'2020-09-01T20:41:15Z'" as "".Recently went through setting up hauser for my business and ran into a couple of issues to I wanted to make sure no one else did as well.