Fixing. Registry Reimplementation. #7
Open
SerhiiRI wants to merge 1 commit intofeat-anchor-patch-printfrom
Open
Fixing. Registry Reimplementation. #7SerhiiRI wants to merge 1 commit intofeat-anchor-patch-printfrom
SerhiiRI wants to merge 1 commit intofeat-anchor-patch-printfrom
Conversation
- REMOVED build-compiler. Will be introduced other options to optimize secondary execution procedure. - ADDED Registry. To already built registry user can attach/remove additional CommandMapSpecs - RENAMED Core, function `create-registry` onto `registry-create` - ADDED Registry Tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the user-perspective
Removed
build-compilerin future releases we'll replace compiler onto the advanced patch system which will be based on Reversed DAG structure passed in secondary time runned execute.
Registry
Registry is now a map-based structure (
{:type spec, ...}) instead of a plain vector.registry-createaccepts both formats:registry-create support optional key
:registry-orderin which you may specify in which order need find-command parse items. (Needed in future features). If the user set only two of 5-th used in registry, it mean that explicitely declareted are going first and other just after(and order doesn't metter)Built registry can be modified with
registry-assoc/registry-dissocwithout rebuilding from scratch.From architecture perspective
how registry has been processed before? we took the registry -> injecting internal cmds -> parsing -> ...executing... -> remove external commands from registry. Work practicaly the same but take a look at the current registry structure:
{:registry {:commando/from {} ...} :registry-order [:commando/from] :registry-validated 1772923734358 :registry-hash -2017569654}before passing this registry the parsing procedure we not extending
:registy, instead we adding key:registry-runtimewhich contains _map,_values,_vec at the end of vector. After the execution is done, we removing:registry-runtime.