Skip to content

fix(jira): Handle quotes in branch names for issue key extraction #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matejsemancik merged 1 commit into from
Jan 21, 2026
Merged

fix(jira): Handle quotes in branch names for issue key extraction #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/actions/jira-transition-tickets/scripts/extract-issue-keys.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ if [[ -n "$MERGED_BRANCHES" ]]; then
IFS=',' read -ra BRANCHES <<< "$MERGED_BRANCHES"
for branch in "${BRANCHES[@]}"; do
# Trim leading/trailing whitespace from branch name
branch=$(echo "$branch" | xargs)
branch="${branch#"${branch%%[![:space:]]*}"}"
branch="${branch%"${branch##*[![:space:]]}"}"
while IFS= read -r key; do
JIRA_KEYS+=("$key")
done < <(echo "$branch" | grep -oE '[A-Z0-9]+-[0-9]+')
Expand Down
15 changes: 15 additions & 0 deletions .github/actions/jira-transition-tickets/test/test_extract-issue-keys.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,3 +183,18 @@ teardown() {
[ "$status" -eq 0 ]
[ "$(grep '^issue_keys=' "$GITHUB_OUTPUT" | cut -d= -f2)" = "PROJ25-123,PROJ25-456" ]
}

@test "extract-issue-keys: handles single quotes" {
run "$BATS_TEST_DIRNAME/../scripts/extract-issue-keys.sh" "Merge remote-tracking branch 'origin/develop, feature/PROJ-1011-eaa-login, futuredapp/feature/PROJ-1009-eaa-intro"

[ "$status" -eq 0 ]
[ "$(grep '^issue_keys=' "$GITHUB_OUTPUT" | cut -d= -f2)" = "PROJ-1009,PROJ-1011" ]
}

@test "extract-issue-keys: handles double quotes" {
run "$BATS_TEST_DIRNAME/../scripts/extract-issue-keys.sh" "Merge remote-tracking branch 'origin/develop', feature/PROJ-1011-eaa-login, futuredapp/feature/PROJ-1009-eaa-intro"

[ "$status" -eq 0 ]
[ "$(grep '^issue_keys=' "$GITHUB_OUTPUT" | cut -d= -f2)" = "PROJ-1009,PROJ-1011" ]
}