feat: add dynamic profile listing to fish shell autocomplete#919
Open
allixsenos wants to merge 1 commit intofwdcloudsec:mainfrom
Open
feat: add dynamic profile listing to fish shell autocomplete#919allixsenos wants to merge 1 commit intofwdcloudsec:mainfrom
allixsenos wants to merge 1 commit intofwdcloudsec:mainfrom
Conversation
Fish completions previously used urfave/cli's static ToFishCompletion() which only generated completions for subcommands and flags. This replaces it with dynamic completion templates that call assumego --generate-bash-completion at tab-completion time, matching the existing zsh behavior and enabling AWS profile listing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
fixes #583 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToFishCompletion(), which only generated completions for subcommands and flags — AWS profile names were never listedassumego --generate-bash-completionat tab-completion time, matching the existing zsh behaviorassumeandgrantedcommandsTest plan
granted completion --shell fishand verify files are created in~/.config/fish/completions/assume+ tab and verify AWS profiles from~/.aws/configand~/.aws/credentialsare listedassume -+ tab still lists flagsgranted+ tab still lists subcommands🤖 Generated with Claude Code