Fix #61: NameError in validate_and_compare_dates due to incorrect _input variables#65
Open
Rahul-2k4 wants to merge 1 commit intofwitmer:masterfrom
Open
Fix #61: NameError in validate_and_compare_dates due to incorrect _input variables#65Rahul-2k4 wants to merge 1 commit intofwitmer:masterfrom
Rahul-2k4 wants to merge 1 commit intofwitmer:masterfrom
Conversation
- Remove buggy lines referencing undefined start_date_input and end_date_input - Use function parameters start_date and end_date correctly - Introduce start_date_dt and end_date_dt for parsed datetime objects - Update docstring format to standard Python documentation style - Improve code clarity and maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61
This PR fixes a critical variable-name bug in
validate_and_compare_dateswithinDeeringAutoDownloadCode.py.Issue:
The function accepts
start_dateandend_dateas parameters but incorrectly attempts to parse undefined variablesstart_date_inputandend_date_input. This caused aNameErrorand broke the date validation flow. These lines were also redundant given the existing parsing logic.Fix:
_inputvariables.start_dateandend_datedirectly for parsing.start_date_dtandend_date_dtfor clarity.This resolves the
NameErrorand restores proper date validation behavior.