Batch requests now have send the correct meta data of the field JSON_…#10
Open
wirdehall wants to merge 1 commit intofxposter:masterfrom
wirdehall:fix_batch_requests
Open
Batch requests now have send the correct meta data of the field JSON_…#10wirdehall wants to merge 1 commit intofxposter:masterfrom wirdehall:fix_batch_requests
wirdehall wants to merge 1 commit intofxposter:masterfrom
wirdehall:fix_batch_requests
Conversation
…RPC_VERSION and thus don't cause the batch request to crash on sensetive servers..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch requests now have send the correct meta data of the field JSON_RPC_VERSION and thus don't cause the batch request to crash on sensetive servers.
Apparently the to_h and to_json method was never called on the request class and so the json version was never set.