Conversation
|
Probably good for me to add some tests for the recipe validators |
|
@brendanreardon Would like your review too |
Aye, aye! Once I get back into building out examples, I'll try running the current recipes through your code here. |
DanielPuthawala
left a comment
DanielPuthawala
left a comment
There was a problem hiding this comment.
Looks good. we talked through the changes earlier, I jst forgot to come back on and submit my review.
brendanreardon
left a comment
brendanreardon
left a comment
There was a problem hiding this comment.
Thank you for this, @korikuzma !! @DanielPuthawala may need to look over these pieces of feedback
| ) | ||
|
|
||
|
|
||
| def test_copy_count_constraint(): |
brendanreardon
left a comment
brendanreardon
left a comment
There was a problem hiding this comment.
🤜 🤛 this looks great! Sorry again for punting on this
|
Just caught up on your guys' back-and-forth. It still looks good to me. Are you going to squash and merge now, Kori? |
3 participants
close #8