Skip to content

Comments

feat!: remove unsafe uses of assert#484

Merged
jsstevenson merged 4 commits intomainfrom
480-assert-bad
Feb 1, 2025
Merged

feat!: remove unsafe uses of assert#484
jsstevenson merged 4 commits intomainfrom
480-assert-bad

Conversation

@jsstevenson
Copy link
Contributor

close #480

@jsstevenson jsstevenson changed the title featremove unsafe uses of assert feat!: remove unsafe uses of assert Jan 31, 2025
@jsstevenson jsstevenson marked this pull request as ready for review January 31, 2025 18:31
@jsstevenson jsstevenson requested review from a team as code owners January 31, 2025 18:31
@jsstevenson jsstevenson added the priority:low Low priority label Jan 31, 2025
Copy link
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating docstrings to include :raises:

@jsstevenson jsstevenson requested a review from korikuzma January 31, 2025 19:05
@jsstevenson jsstevenson merged commit f38cbca into main Feb 1, 2025
14 checks passed
@jsstevenson jsstevenson deleted the 480-assert-bad branch February 1, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:low Low priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all assert instances in library code

3 participants