feat!: streamline annotator interface + refactor internals#487
Closed
jsstevenson wants to merge 15 commits intomainfrom
Closed
feat!: streamline annotator interface + refactor internals#487jsstevenson wants to merge 15 commits intomainfrom
jsstevenson wants to merge 15 commits intomainfrom
Conversation
Contributor
Author
|
I think I've now put up PRs for everything that I'd originally done here, so I can close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #482
Breaking changes
annotatorsubmodule that housescliandvcfmodules. We've talked for a while about the naming incongruity betweenvcf_annotation.pyandtranslator.py, so I resolved that + divided functionality out by CLI vs format-specific considerations.conftest.py, all tests after the first one stop sending requests to the dataproxy (i.e. they wouldn't trip any of the cassettes) because they are all LRU cache hits. I have a separate PR to alter the dataproxy fixture's scope, but that potentially comes with costs. As an intermediary measure, I made a separate case-scoped fixture just for the VCF tests module.Pathsrather thanstrsOther notable changes