feat!: break annotator tools into separate submodule#494
Merged
jsstevenson merged 3 commits intomainfrom Feb 5, 2025
Merged
Conversation
korikuzma
reviewed
Feb 5, 2025
tests/extras/test_annotate_vcf.py
Outdated
| @pytest.mark.vcr | ||
| def test_get_vrs_object_invalid_input(vcf_annotator, caplog): | ||
| """Test that _get_vrs_object method works as expected with invalid input""" | ||
| # some tests are check |
Contributor
There was a problem hiding this comment.
Don't think this is complete?
Contributor
Author
There was a problem hiding this comment.
Yeah not sure what happened there
Contributor
Author
There was a problem hiding this comment.
The author was assassinated mid-sentence
korikuzma
approved these changes
Feb 5, 2025
korikuzma
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vcf_annotation.pyandtranslator.py. This makes the former consistent with the latter.annotatora package withinextras, containing avcfmodule. Also breaks the CLI into a separate module.proposed module structure: