Skip to content

feat!: make annotator exception conform to pep8 naming #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsstevenson merged 1 commit into from
Feb 5, 2025
Merged

feat!: make annotator exception conform to pep8 naming #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ga4gh/vrs/extras/vcf_annotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
_logger.setLevel(logging.DEBUG)


class VCFAnnotatorException(Exception): # noqa: N818
class VCFAnnotatorError(Exception):
"""Custom exceptions for VCF Annotator tool"""


Expand Down Expand Up @@ -291,7 +291,7 @@ def annotate(
"""
if not any((vcf_out, vrs_pickle_out)):
msg = "Must provide one of: `vcf_out` or `vrs_pickle_out`"
raise VCFAnnotatorException(msg)
raise VCFAnnotatorError(msg)

info_field_num = "R" if compute_for_ref else "A"
info_field_desc = "REF and ALT" if compute_for_ref else "ALT"
Expand Down
4 changes: 2 additions & 2 deletions tests/extras/test_vcf_annotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import pytest

from ga4gh.vrs.dataproxy import DataProxyValidationError
from ga4gh.vrs.extras.vcf_annotation import VCFAnnotator, VCFAnnotatorException
from ga4gh.vrs.extras.vcf_annotation import VCFAnnotator, VCFAnnotatorError

TEST_DATA_DIR = "tests/extras/data"

Expand Down Expand Up @@ -160,7 +160,7 @@ def test_annotate_vcf_vcf_only(vcf_annotator, vcr_cassette):
def test_annotate_vcf_input_validation(vcf_annotator):
input_vcf = f"{TEST_DATA_DIR}/test_vcf_input.vcf"

with pytest.raises(VCFAnnotatorException) as e:
with pytest.raises(VCFAnnotatorError) as e:
vcf_annotator.annotate(input_vcf)
assert str(e.value) == "Must provide one of: `vcf_out` or `vrs_pickle_out`"

Expand Down
Loading