Skip to content

Comments

feat!: use pathlib.Paths + streamline related checks #496

Merged
jsstevenson merged 5 commits intomainfrom
annotator-path-args
Feb 5, 2025
Merged

feat!: use pathlib.Paths + streamline related checks #496
jsstevenson merged 5 commits intomainfrom
annotator-path-args

Conversation

@jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Feb 5, 2025

  • use pathlib.Path where appropriate rather than using raw strings
  • make variable names a bit clearer + break up the path vars vs the corresponding handlers (previously they were being reassigned which makes for messiness when running type checkers)
  • streamline a bunch of checks relating to whether a given output file is going to be created. Previously there were a lot of redundant variables and args being passed around. The signatures on some of these methods were getting pretty hairy otherwise.
  • refactor tests to use temp files where available + consolidate inputs

@jsstevenson jsstevenson marked this pull request as ready for review February 5, 2025 21:32
@jsstevenson jsstevenson requested review from a team as code owners February 5, 2025 21:32
@jsstevenson jsstevenson added the priority:medium Medium priority label Feb 5, 2025
@jsstevenson jsstevenson merged commit c7b3733 into main Feb 5, 2025
14 checks passed
@jsstevenson jsstevenson deleted the annotator-path-args branch February 5, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants