feat: Add --manager flag to CLI project create command (#1410) - #606
feat: Add --manager flag to CLI project create command (#1410)#606sd66dar wants to merge 1 commit into
Conversation
eamansour
left a comment
There was a problem hiding this comment.
Thanks for taking on this story! The changes are looking great, I've just added a few comments/suggestions that would be great to go through whenever you can :)
jadecarino
left a comment
There was a problem hiding this comment.
Thanks very much for this PR Sheriell! Really keen to get this feature into Galasa. Changes look great overall, I have a few additional minor comments in addition to Eamonn's. Let us know if you'd like to discuss any requested changes!
jadecarino
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments Sheriell! I've resolved all of my original comments and I have one 1-line change remaining that I just noticed.
In terms of Eamonn's comments, as part of this PR, please can we also get the build issue resolved as well as add the missing Javadoc to ManagerImpl and the missing properties and resource management template files.
We would be happy for you to add the documentation to docs and tackle the more complex issue of adding a manager to an existing test project in a second PR.
eamansour
left a comment
There was a problem hiding this comment.
Thanks for making those changes! One small comment but overall the code changes look good - happy to approve once the comment is sorted out :)
Resolves galasa-dev/projectmanagement#1410 Adds --manager and --managerName flags to galasactl project create. Generates a complete manager project including interface, implementation, annotations, resources, CPS properties, unit tests, OSGi bundle config, and OBR integration. Supports both Maven and Gradle build systems. Signed-off-by: Sheriell Dar <asd638796@gmail.com>
a4d126c to
8d89927
Compare
Refer to galasa-dev/projectmanagement#1410.
Summary
Implements #1410 to add manager project creation capability to the Galasa CLI. The new
--managerflag allows developers to generate a complete manager project structure with all necessary components.CLI Enhancement
--managerflag togalasactl project createcommand--managerNameparameter for specifying manager name--managerand--featuresflagsManager Project Generation
The tool generates a complete manager project including:
IManager.java) - Public API for the managerManagerImpl.java) - Core manager logic with lifecycle methodsManager.java) - For injecting the manager into test classesIManagerResource.java) - Public API for managed resourcesResourceImpl.java) - Resource implementation with null safetyManagerImplTest.java) - JUnit 5 test suiteTesting
build-locally.shDocumentation
--managerflag usage and examples