Skip to content

a missing features for GLRD and gardenlinux's tests - #132

Merged
NotTheEvilOne merged 7 commits into
mainfrom
feat/glrd_missing_features
Aug 12, 2025
Merged

a missing features for GLRD and gardenlinux's tests#132
NotTheEvilOne merged 7 commits into
mainfrom
feat/glrd_missing_features

Conversation

@yeoldegrove

@yeoldegrove yeoldegrove commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

In the latest refactoring a few features got lost that GLRD and gardenlinux's tests are currently depending on.

This PR adds those features back:

@yeoldegrove yeoldegrove self-assigned this Jul 1, 2025
@yeoldegrove
yeoldegrove force-pushed the feat/glrd_missing_features branch 3 times, most recently from 2c2d551 to 482b235 Compare July 2, 2025 05:48
@yeoldegrove yeoldegrove changed the title a missing features for GLRD a missing features for GLRD and gardenlinux's tests Jul 16, 2025
@yeoldegrove
yeoldegrove marked this pull request as draft July 16, 2025 08:18

@NotTheEvilOne NotTheEvilOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @yeoldegrove. Do you mind splitting this PR for:

  • "GitHub" functionality
  • S3 extension

Comment thread src/gardenlinux/flavors/__main__.py Outdated
Comment thread src/gardenlinux/github/__init__.py Outdated
Comment thread src/gardenlinux/github/github.py Outdated
Comment thread src/gardenlinux/github/github.py Outdated
Comment thread src/gardenlinux/s3/s3_object_index.py Outdated
Comment thread src/gardenlinux/s3/s3_object_index.py Outdated
@NotTheEvilOne NotTheEvilOne self-assigned this Jul 31, 2025
@NotTheEvilOne
NotTheEvilOne self-requested a review July 31, 2025 12:37
@NotTheEvilOne
NotTheEvilOne force-pushed the feat/glrd_missing_features branch 5 times, most recently from 5cfa3e4 to 0eb399f Compare August 11, 2025 15:13
@NotTheEvilOne
NotTheEvilOne force-pushed the feat/glrd_missing_features branch from 0eb399f to b676dd1 Compare August 11, 2025 15:45
@codecov

codecov Bot commented Aug 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.32%. Comparing base (7933a0f) to head (01fda54).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/gardenlinux/flavors/__main__.py 95.23% 1 Missing ⚠️
src/gardenlinux/s3/bucket.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   72.73%   73.32%   +0.59%     
==========================================
  Files          27       27              
  Lines        1192     1226      +34     
==========================================
+ Hits          867      899      +32     
- Misses        325      327       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NotTheEvilOne
NotTheEvilOne force-pushed the feat/glrd_missing_features branch 3 times, most recently from 31eec24 to 70f4673 Compare August 12, 2025 08:11
@NotTheEvilOne
NotTheEvilOne marked this pull request as ready for review August 12, 2025 09:02
@NotTheEvilOne
NotTheEvilOne force-pushed the feat/glrd_missing_features branch from be67932 to b0fd8ca Compare August 12, 2025 09:22
@NotTheEvilOne
NotTheEvilOne requested review from ByteOtter, NotTheEvilOne and commel and removed request for NotTheEvilOne August 12, 2025 09:25
@NotTheEvilOne
NotTheEvilOne self-requested a review August 12, 2025 09:26
@NotTheEvilOne
NotTheEvilOne force-pushed the feat/glrd_missing_features branch from b0fd8ca to e273982 Compare August 12, 2025 09:26

@ByteOtter ByteOtter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far, most gripes I have are nitpicks about code style that we can address later with CI.
Only thing I would like to have changed is the name of the test function in test_bucket as its currently not being executed as far as I see because pytest can't detect it without the test_ prefix.
Fell free to treat all other comments as optional.

Comment thread tests/s3/test_bucket.py Outdated
Comment thread src/gardenlinux/s3/bucket.py Outdated
Comment thread src/gardenlinux/git/git.py
Comment thread src/gardenlinux/flavors/__main__.py
Comment thread src/gardenlinux/flavors/__main__.py
Comment thread src/gardenlinux/s3/bucket.py
@ByteOtter

Copy link
Copy Markdown
Contributor

When it comes to other test coverage, I can bring that back up later :)

Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
@NotTheEvilOne
NotTheEvilOne force-pushed the feat/glrd_missing_features branch 3 times, most recently from 5a6e0cc to 38a968d Compare August 12, 2025 11:03
@NotTheEvilOne
NotTheEvilOne dismissed their stale review August 12, 2025 11:05

Removing review as during absence I took over @yeoldegrove work and it looks like I can't remove the "request changes" status of the first review otherwise.

Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
@NotTheEvilOne
NotTheEvilOne force-pushed the feat/glrd_missing_features branch from 38a968d to 01fda54 Compare August 12, 2025 11:05
@NotTheEvilOne
NotTheEvilOne requested review from ByteOtter and removed request for NotTheEvilOne August 12, 2025 11:06

@ByteOtter ByteOtter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the handling of file operations causes me a slight tummy ache. I trust your judgement and approve this.
Maybe we can revisit this later.

@NotTheEvilOne
NotTheEvilOne merged commit 6a096d8 into main Aug 12, 2025
15 checks passed
@NotTheEvilOne
NotTheEvilOne deleted the feat/glrd_missing_features branch August 12, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants