Skip to content

Typing: Fix pyright type issues in apt module - #201

Merged
ByteOtter merged 1 commit into
mainfrom
lint/fix-pyright-issues
Sep 24, 2025
Merged

Typing: Fix pyright type issues in apt module#201
ByteOtter merged 1 commit into
mainfrom
lint/fix-pyright-issues

Conversation

@ByteOtter

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR is the first of a series that fixes all issues raised by pyright.
In this case, it fixes smaller typing issues within the apt module that are caused by inaccurate function signatures not reflecting possible None values.

It does not change the underlying logic, but adjusts the function signatures to reflect the types correctly.

Which issue(s) this PR fixes:
Tracks #152

@codecov

codecov Bot commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.23%. Comparing base (76dcb4e) to head (8cf0fa2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          30       30           
  Lines        1375     1375           
=======================================
  Hits         1282     1282           
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NotTheEvilOne NotTheEvilOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ByteOtter
ByteOtter merged commit b0f7ceb into main Sep 24, 2025
9 of 11 checks passed
@ByteOtter
ByteOtter deleted the lint/fix-pyright-issues branch September 24, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants