Skip to content

Lint: Fix pyright errors in s3 module - #204

Merged
vivus-ignis merged 5 commits into
mainfrom
lint/fix-s3-module
Sep 29, 2025
Merged

Lint: Fix pyright errors in s3 module#204
vivus-ignis merged 5 commits into
mainfrom
lint/fix-s3-module

Conversation

@ByteOtter

@ByteOtter ByteOtter commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Fixes mainly typing issues in the s3 module, mainly by explicitly casting or typing as Noneable.

Which issue(s) this PR fixes:
Tracks #152

@codecov

codecov Bot commented Sep 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.03%. Comparing base (ef7d368) to head (dc3bd9f).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/gardenlinux/s3/bucket.py 90.00% 1 Missing ⚠️
src/gardenlinux/s3/s3_artifacts.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   93.22%   89.03%   -4.20%     
==========================================
  Files          30       33       +3     
  Lines        1372     1495     +123     
==========================================
+ Hits         1279     1331      +52     
- Misses         93      164      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ByteOtter
ByteOtter force-pushed the lint/fix-s3-module branch 2 times, most recently from d9179db to 2fd3378 Compare September 25, 2025 09:45
Comment thread src/gardenlinux/s3/bucket.py
Comment thread tests/s3/test_s3_artifacts.py
Comment thread tests/s3/test_s3_artifacts.py
Comment thread tests/s3/test_s3_artifacts.py
@vivus-ignis
vivus-ignis self-requested a review September 29, 2025 09:10
@vivus-ignis
vivus-ignis merged commit 1dd8878 into main Sep 29, 2025
7 of 11 checks passed
@ByteOtter
ByteOtter deleted the lint/fix-s3-module branch September 29, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants