Added OS X ChangeMonitor support; fixed memory leak in Platform::GetFiles.#16
Open
Bo98 wants to merge 5 commits into
Open
Added OS X ChangeMonitor support; fixed memory leak in Platform::GetFiles.#16Bo98 wants to merge 5 commits into
Bo98 wants to merge 5 commits into
Conversation
|
I am astonished by the fact that these filesystem event things are heartless b**es (whisperity/SharpGMad@d1b29d7) in cross-platform. |
Contributor
Author
|
Yup, and I changed it again because I just realised GMod's autorefresh reads the whole of the garrysmod folder (including server downloads) which got me past the system-wide file descriptor limit. It does require linking CoreServices now but based on the Source SDK (https://github.com/ValveSoftware/source-sdk-2013/blob/56accfdb9c4abd32ae1dc26b2e4cc87898cf4dc1/mp/src/tier1/fileio.cpp#L15), GMod should already be doing that. Hopefully it doesn't throw off others using Bootil though. I'll probably add a #define before it's merged into the repo once I know it works in GMod. I'll also squash the commits then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.