Skip to content

fix(skill-check): honor primary host skipSkills in Templates check #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EricXu-0805 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix(skill-check): honor primary host skipSkills in Templates check #1430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scripts/skill-check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import { validateSkill } from '../test/helpers/skill-parser';
import { discoverTemplates, discoverSkillFiles } from './discover-skills';
import { claude as PRIMARY_HOST } from '../hosts/index';
import * as fs from 'fs';
import * as path from 'path';
import { execSync } from 'child_process';
Expand Down Expand Up @@ -64,15 +65,25 @@ for (const file of SKILL_FILES) {

console.log('\n Templates:');
const TEMPLATES = discoverTemplates(ROOT);
// Repo-root SKILL.md outputs reflect what the primary host (claude) generates.
// If a skill is in claude's skipSkills (e.g. the `/claude` outside-voice skill
// is intentionally not bundled into the Claude host), its generated file is
// expected to be absent — flagging it as missing here is a false positive.
const PRIMARY_SKIP_SKILLS = new Set(PRIMARY_HOST.generation?.skipSkills ?? []);

for (const { tmpl, output } of TEMPLATES) {
const tmplPath = path.join(ROOT, tmpl);
const outPath = path.join(ROOT, output);
const skillDir = output.includes('/') ? output.split('/')[0] : '';
if (!fs.existsSync(tmplPath)) {
console.log(` \u26a0\ufe0f ${output.padEnd(30)} — no template`);
continue;
}
if (!fs.existsSync(outPath)) {
if (skillDir && PRIMARY_SKIP_SKILLS.has(skillDir)) {
console.log(` - ${output.padEnd(30)} — skipped per ${PRIMARY_HOST.name} host config`);
continue;
}
hasErrors = true;
console.log(` \u274c ${output.padEnd(30)} — generated file missing! Run: bun run gen:skill-docs`);
continue;
Expand Down