fix(setup,browse): support GSTACK_SKIP_PLAYWRIGHT and fix system chromium test execution#1455
Open
joseironchip wants to merge 1 commit into
Open
fix(setup,browse): support GSTACK_SKIP_PLAYWRIGHT and fix system chromium test execution#1455joseironchip wants to merge 1 commit into
joseironchip wants to merge 1 commit into
Conversation
…mium test execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the freezing and crashing issues during
./setupon non-Ubuntu Linux environments (such as Arch Linux or NixOS) when trying to bypass the default Playwright browser bundle download.Changes
GSTACK_SKIP_PLAYWRIGHThandling logic inside the main setup execution pipeline.ensure_playwright_browser()under the skip parameter to temporarily appendplaywrightlocally to development dependencies (--dev) and map toGSTACK_CHROMIUM_PATHwith a sandbox-free environment./browse/src/browser-manager.tsand/browse/test/bridge-chromium-e2e.test.tsto inheritGSTACK_CHROMIUM_PATH, adding explicitheadless: trueand sandbox arguments to ensure tests can pass successfully using the system browser.README.mdto guide Arch Linux/NixOS users.Closes #913
Need help on this PR? Tag
@codesmithwith what you need.