fix(browse): use CDP websocket fallback on Windows#84
Open
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Open
fix(browse): use CDP websocket fallback on Windows#84mvanhorn wants to merge 1 commit intogarrytan:mainfrom
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Conversation
Bun's pipe transport hangs when Playwright launches Chromium on Windows (garrytan#77). Detect Windows and pass --remote-debugging-port=0 to use websocket transport instead. macOS/Linux behavior is unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.platform === 'win32') inbrowser-manager.tsand launches Chromium with--remote-debugging-port=0to use websocket transport instead of the default pipe transportFixes #77. Bun's child process pipe implementation does not work with Playwright's
--remote-debugging-pipeon Windows. Chromium launches but the DevTools Protocol pipe never connects, causing an indefinite hang. This adds a platform check that uses websocket transport on Windows, bypassing the broken pipe.Test plan
bun testpasses on macOS/Linux (no regression)browse goto https://example.comno longer hangs on WindowsisHealthy()works with CDP-connected browserrecreateContext()saves/restores state correctly