DCache implementation by ninaiiad · Pull Request #39 · gattaca-com/flux

ninaiiad · 2026-03-05T16:28:36Z

louisponet

what happens if someone was reading the data while another one overwrites it? Do we assume that will just not happen? I think that's ok but also quite dangerous.

crates/flux-utils/src/datastore.rs

gd-0

can you write a bench for this and compare it vs crossbeam?

crates/flux-utils/src/dcache.rs

crates/flux-utils/src/datastore.rs

crates/flux-utils/src/dcache.rs

crates/flux-utils/src/datastore.rs

crates/flux-utils/src/dcache.rs

crates/flux-utils/src/datastore.rs

crates/flux-utils/benches/dcache.rs

crates/flux-utils/src/datastore.rs

crates/flux-utils/src/dcache.rs

crates/flux-utils/benches/dcache.rs

crates/flux-utils/src/dcache.rs

vladimir-ea · 2026-03-10T17:53:56Z

crates/flux-utils/src/dcache.rs

+                base.add(offset_ix + Self::OFFSET),
+                buf.as_mut_ptr(),
+                r.len,
+            );


what prevents the slice of the buffer that is being read from being written concurrently?

nothing, the reader will find out whether or not this happened after the function has completed

ltitanb

lgtm

ninaiiad requested a review from a team March 5, 2026 16:28

This comment was marked as resolved.

Sign in to view

datastore

316aebd

ninaiiad force-pushed the ng/dcache branch from 15cd84e to 316aebd Compare March 5, 2026 16:49

This comment was marked as resolved.

Sign in to view

louisponet reviewed Mar 5, 2026

View reviewed changes

crates/flux-utils/src/datastore.rs Outdated Show resolved Hide resolved

crates/flux-utils/src/datastore.rs Outdated Show resolved Hide resolved

ninaiiad commented Mar 5, 2026

View reviewed changes

crates/flux-utils/src/datastore.rs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

ninaiiad commented Mar 5, 2026

View reviewed changes

crates/flux-utils/src/datastore.rs Outdated Show resolved Hide resolved

gd-0 reviewed Mar 5, 2026

View reviewed changes

crates/flux-utils/src/dcache.rs Show resolved Hide resolved

gd-0 reviewed Mar 5, 2026

View reviewed changes

ninaiiad added 3 commits March 6, 2026 10:27

fixes

3b888c6

map

929745a

bench draft

0bc897d

ninaiiad force-pushed the ng/dcache branch from a829546 to 0bc897d Compare March 6, 2026 16:06

This comment was marked as resolved.

Sign in to view

ninaiiad commented Mar 6, 2026

View reviewed changes

crates/flux-utils/benches/dcache.rs Show resolved Hide resolved

map buf fix

6b5054c

ninaiiad commented Mar 6, 2026

View reviewed changes

crates/flux-utils/src/datastore.rs Outdated Show resolved Hide resolved

accept closure

0b6d47a

gd-0 reviewed Mar 6, 2026

View reviewed changes

crates/flux-utils/src/datastore.rs Outdated Show resolved Hide resolved

crates/flux-utils/src/datastore.rs Outdated Show resolved Hide resolved

crates/flux-utils/src/dcache.rs Show resolved Hide resolved

ninaiiad changed the title ~~DataStore / DCache implementation~~ DCache implementation Mar 8, 2026

This comment was marked as resolved.

Sign in to view

rename+

a63be66

ninaiiad force-pushed the ng/dcache branch from e8b2302 to a63be66 Compare March 8, 2026 10:21

louisponet reviewed Mar 9, 2026

View reviewed changes

crates/flux-utils/src/dcache.rs Outdated Show resolved Hide resolved

crates/flux-utils/src/dcache.rs Outdated Show resolved Hide resolved

crates/flux-utils/src/dcache.rs Outdated Show resolved Hide resolved

crates/flux-utils/src/dcache.rs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

offset + benches

852be78

ninaiiad force-pushed the ng/dcache branch from 2f90345 to 852be78 Compare March 9, 2026 17:41

This comment was marked as resolved.

Sign in to view

ninaiiad force-pushed the ng/dcache branch from 63c8fcf to 5491118 Compare March 9, 2026 18:14

compiler fence

4a14e40

ninaiiad force-pushed the ng/dcache branch from 5491118 to 4a14e40 Compare March 9, 2026 18:31

allocate on the heap

86432b5

ninaiiad force-pushed the ng/dcache branch from 8f6f910 to 86432b5 Compare March 10, 2026 11:25

two slices in map too

02abc25

louisponet reviewed Mar 10, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

ninaiiad force-pushed the ng/dcache branch from 2e3721f to 0a6ebe7 Compare March 10, 2026 16:31

This comment was marked as resolved.

Sign in to view

ninaiiad force-pushed the ng/dcache branch from 0a6ebe7 to b03b73a Compare March 10, 2026 16:42

This comment was marked as resolved.

Sign in to view

ninaiiad force-pushed the ng/dcache branch from b03b73a to 0007531 Compare March 10, 2026 16:56

draft

5ba5011

ninaiiad force-pushed the ng/dcache branch from 0007531 to 5ba5011 Compare March 10, 2026 17:03

vladimir-ea reviewed Mar 10, 2026

View reviewed changes

cleanup

b2be28f

ltitanb approved these changes Mar 10, 2026

View reviewed changes

ninaiiad merged commit a42ef4b into main Mar 10, 2026
1 check passed

ninaiiad deleted the ng/dcache branch March 11, 2026 09:21

Conversation

ninaiiad commented Mar 5, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

louisponet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

gd-0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

vladimir-ea Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

ninaiiad Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

ltitanb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ninaiiad commented Mar 5, 2026 •

edited by devin-ai-integration bot

Loading