This repository was archived by the owner on May 24, 2025. It is now read-only.
fix up delegated methods in distributed server, patch compatibility fix for Ruby 2.4 - #392
Open
damienrch wants to merge 1 commit into
Open
fix up delegated methods in distributed server, patch compatibility fix for Ruby 2.4#392damienrch wants to merge 1 commit into
damienrch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the delegator methods in Ruby 2.4. Changes to Ruby introduced a compile which blows up delegated methods that eval:
iseq = RubyVM::InstructionSequence.compile("().#{method}", nil, nil, 0, false)Change introduced here:
ruby/ruby@2283d14#diff-f8ad465135e9b25d06e71454b6e18317R6
I'm aware your other commit which fixes this removes
$SAFE = 1, but I guess this allows you keep the safety. Not entirely sure of the implications of removing (perhaps isn't such a big deal). Sucks that CI is wailing :/