Add more VRAM constants - #85
Conversation
|
I'd suggest picking up the conversation from #18 and challenge e.g. #18 (comment) which summed it up why at the time we were removing those. Also, not strictly related, but please don't use ...and we already have some “spatially redundant but semantically distinct” duplicates anyway. as an argument to this. The existence of prior exceptions doesn't create a general license. Those may have been ad-hoc exceptions, things that are just waiting to be worked on, or simply... debt (and we don't want debt, let alone self-reinforcing debt) |
|
@avivace Re: the conversation in #18, I addressed that in the issue #84 discussion. (I wasn't expecting a PR to exist this soon.) Re: the unrelated We've already cleaned up almost all "debt" by moving old constants to The "spatially redundant but semantically distinct" constants we still have are recent ones:
My impression is that by now these aren't "ad-hoc exceptions", but are our accepted standard method for how to deal with semantic ambiguity. (It's basically the same principle as having two constants |
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
|
Merging this PR due to lack of negative feedback in the last three months, and positive demand (#84 (comment)). |
The last commit to this PR was just today (the I approve of it as-is, and am waiting for @avivace to review this and the other recent PRs. |
Tile block addresses as per the consensus thus far in #84, and also some attrmap addresses because I remember being confused as to their locations, and I think that:
...and we already have some “spatially redundant but semantically distinct” duplicates anyway.
(Resolves #84.)