Rename _AUD3WAVERAM to AUD3WAVERAM - #86
Merged
Merged
Conversation
ISSOtm
reviewed
Aug 6, 2026
ISSOtm
left a comment
ISSOtm
left a comment
Member
There was a problem hiding this comment.
I'm wondering whether we should call it just AUD3WAVE. I know that's not consistent with historical naming, but that's not stopped us before; it would feel more consistent with other MMIO naming, too. (Not feeling strongly about it, but I feel it's worth thinking about.)
Collaborator
Author
|
I think |
Member
|
Fair point, by that line of thinking I think the current naming is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64