Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on visual and accessibility improvements, dark mode handling, and code consistency across the application. The most significant changes are grouped below:
Visual and Theming Improvements:
index.htmlandpublic/manifest.jsonto a new blue shade (#0ea5e9) for a more consistent brand appearance. [1] [2]manifest.jsonby using maskable icons for better PWA support and adding a 1024x1024 icon for high-resolution devices.src/assets/main.cssto ensure proper background and text color inheritance for both light and dark modes, and improved animation keyframe formatting for readability. [1] [2] [3]Dark Mode and Accessibility:
src/App.vueand instead rely on global CSS classes for dark mode, simplifying the handling of dark mode throughout the app.BaseBottomNav.vueby hiding navigation labels visually and exposing them to screen readers only, making the bottom navigation more accessible.Code Consistency and Formatting:
BaseAlert.vue,BaseBadge.vue,BaseButton.vue,BaseCard.vue) for cleaner and more maintainable code. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]DatasetUpdateProgress.vueandBaseCard.vue. [1] [2] [3]StorageQuotaDisplay.vue.These changes collectively enhance the application's appearance, accessibility, and code quality.