Skip to content

fix: light mode toggle#37

Merged
gcharest merged 4 commits intomainfrom
fix/v05_light_mode
Dec 20, 2025
Merged

fix: light mode toggle#37
gcharest merged 4 commits intomainfrom
fix/v05_light_mode

Conversation

@gcharest
Copy link
Owner

This pull request focuses on visual and accessibility improvements, dark mode handling, and code consistency across the application. The most significant changes are grouped below:

Visual and Theming Improvements:

  • Updated the primary theme color and background color in both index.html and public/manifest.json to a new blue shade (#0ea5e9) for a more consistent brand appearance. [1] [2]
  • Improved icon handling in manifest.json by using maskable icons for better PWA support and adding a 1024x1024 icon for high-resolution devices.
  • Enhanced base CSS in src/assets/main.css to ensure proper background and text color inheritance for both light and dark modes, and improved animation keyframe formatting for readability. [1] [2] [3]

Dark Mode and Accessibility:

  • Removed explicit dark mode toggling logic from src/App.vue and instead rely on global CSS classes for dark mode, simplifying the handling of dark mode throughout the app.
  • Improved accessibility in BaseBottomNav.vue by hiding navigation labels visually and exposing them to screen readers only, making the bottom navigation more accessible.

Code Consistency and Formatting:

  • Standardized trailing commas and formatting in computed property objects and arrays across multiple components (BaseAlert.vue, BaseBadge.vue, BaseButton.vue, BaseCard.vue) for cleaner and more maintainable code. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]
  • Improved template readability and formatting in several components, such as DatasetUpdateProgress.vue and BaseCard.vue. [1] [2] [3]
  • Minor improvements to CSS transitions and formatting in StorageQuotaDisplay.vue.

These changes collectively enhance the application's appearance, accessibility, and code quality.

@gcharest gcharest merged commit 65fdaf3 into main Dec 20, 2025
8 checks passed
@gcharest gcharest deleted the fix/v05_light_mode branch December 20, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant