Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces major improvements to the PWA app features including meal history export/import, tags and user management. Additional end-to-end (E2E) and smoke testing workflows, enhances accessibility test reliability, and updates documentation with new feature planning. The most significant changes include a new sharded E2E test strategy for faster CI, a unified smoke test job for PRs, robust handling of update dialogs in accessibility tests, and planning for a detailed meal history view and editing. There are also updates to PWA installation tests to make them more robust and environment-agnostic.
CI/CD Workflow Improvements:
e2e-shardedjob and report merging, and separated nightly/multi-browser tests intoe2e-multi-browserfor comprehensive coverage. [1] [2] [3] [4]e2e-smokejob that runs both accessibility and installation smoke tests for faster, more relevant feedback on pull requests. [1] [2]Accessibility and E2E Test Reliability:
dismissUpdateDialogs) to the accessibility tests to programmatically hide update dialogs and notifications, reducing flakiness from overlays interfering with automated checks. [1] [2] [3] [4] [5]Documentation and Feature Planning:
These changes collectively make the CI pipeline faster and more reliable, improve the robustness of E2E and accessibility tests, and lay the groundwork for significant new user-facing features.