feat: add option to convert tabs into spaces#3
Merged
deevus merged 5 commits intogdzig:mainfrom Nov 19, 2025
Merged
Conversation
Contributor
Author
|
For changes required on the gdzig side of things, we would just need to add this argument to the renderDocument call in docs.zig: try bbcodez.fmt.md.renderDocument(allocator, doc, &output.writer, .{
.write_element_fn = writeElement,
.user_data = @ptrCast(@constCast(&doc_ctx)),
.convert_tab_size = 4, // new, may want to put as a const at the top of file.
}); |
deevus
approved these changes
Nov 19, 2025
Collaborator
|
Nice one. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional argument
convert_tab_sizeto CLI and Markdown formatter options. The argument is optional the user may provide an integer in the range of [0, 255] to convert tabs into that number of spaces.I just used
replaceOwnedto do this as that is what was already being done with turning\nto\n\nbut this could be a point of improvement, changing points where we replace these with a alloc-less writer.I was struggling run the executable for bbcodez to test this so I needed to make some additional fixes:
Fixes:
createFileinstead ofopenFilefor creating the output file.bbcode:
generated markdown (4 space tabs):
Closes #1