Add install() commands to CMake, lower min C++ standard to 14#3
Open
valgur wants to merge 1 commit intogegles:mainfrom
Open
Add install() commands to CMake, lower min C++ standard to 14#3valgur wants to merge 1 commit intogegles:mainfrom
valgur wants to merge 1 commit intogegles:mainfrom
Conversation
Author
|
@gegles Are you preferring to keep the CMakeLists.txt simple and not include the standard |
Owner
|
@valgur, so sorry, I thought this PR was old/stale... Happy to merge in any improvements you want, please just update and resolve conflicts with the latest. I/We primarily use So, as long as we keep that going I am good. The version typically comes from Conan, here, but I/we can figure the best practice for things to work... Same for the C++ standard... I just bumped it up to C++20 but if we want/need to bring it back down to 14, for better backward compat, I am fine with that as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the CMake config creation and
install()commands from the original repo.I would like to add this library as a Vcpkg package and a proper CMake installation setup is required for that.
I tested the
test_packagewith C++14 and it built fine with the lower C++ standard.Bumped the Conan dependency versions to get rid of conflicts.
transitive_headersetc are not needed whenpackage_type = "header-library"is set.I tested the installed output with
test_packageand it worked fine.