Fix GitHub integration settings#1045
Open
thisisharsh7 wants to merge 4 commits intogeneralaction:mainfrom
Open
Fix GitHub integration settings#1045thisisharsh7 wants to merge 4 commits intogeneralaction:mainfrom
thisisharsh7 wants to merge 4 commits intogeneralaction:mainfrom
Conversation
|
@thisisharsh7 is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR fixes GitHub integration settings by implementing proper logout from Key changes:
Confidence Score: 3/5
|
| Filename | Overview |
|---|---|
| src/main/services/GitHubService.ts | Updated logout to clear both gh CLI auth and keychain token; uses hardcoded /bin/bash shell which may fail on Windows |
| src/renderer/components/IntegrationsCard.tsx | Added GitHub modal display and status polling after login/logout; includes 3-second polling with 15 attempts after successful auth |
Last reviewed commit: 925c086
src/main/services/GitHubService.ts
Outdated
| // Run both operations in parallel since they're independent | ||
| await Promise.allSettled([ | ||
| // Logout from gh CLI | ||
| execAsync('echo "" | gh auth logout --hostname github.com', { shell: '/bin/bash' }).catch( |
There was a problem hiding this comment.
hardcoded /bin/bash will fail on Windows
Suggested change
| execAsync('echo "" | gh auth logout --hostname github.com', { shell: '/bin/bash' }).catch( | |
| execAsync('echo "" | gh auth logout --hostname github.com').catch( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1036