fix(terminal): auto-switch to Run tab and remove horizontal scroll in lifecycle logs#1046
Open
beks-m wants to merge 1 commit intogeneralaction:mainfrom
Open
fix(terminal): auto-switch to Run tab and remove horizontal scroll in lifecycle logs#1046beks-m wants to merge 1 commit intogeneralaction:mainfrom
beks-m wants to merge 1 commit intogeneralaction:mainfrom
Conversation
… lifecycle logs When clicking Play to start a lifecycle run script, the dropdown now automatically switches to the Run tab so logs are visible immediately. Also fixes horizontal scrolling in lifecycle log output by wrapping long lines, matching the terminal view's behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@beks-m is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryAdded reactive auto-switching to the Run lifecycle tab when a run script starts, and fixed horizontal scrolling in lifecycle logs by wrapping long lines. Key Changes:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| src/renderer/components/TaskTerminalPanel.tsx | Added auto-switch to Run tab when lifecycle starts and fixed horizontal scroll in lifecycle logs with text wrapping |
Last reviewed commit: 3585b5e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whitespace-pre-wrap break-words), matching the terminal view's behaviorDetails
Auto-switch to Run tab: Added a
useEffectthat watchesrunStatus. When it transitions to'running'(via lifecycle event), the dropdown automatically switches tolifecycle::run. This is reactive rather than imperative — it responds to the actual state change instead of setting state inside the click handler (which was interfering with the API call).Horizontal scroll fix: Changed the
<pre>element fromoverflow-autotooverflow-y-auto overflow-x-hidden whitespace-pre-wrap break-words. The terminal view (xterm.js) wraps text internally, but the lifecycle logs used a raw<pre>that preserved all whitespace without wrapping, causing unwanted horizontal scroll.Test plan
runscript in.emdash.json🤖 Generated with Claude Code