-
Notifications
You must be signed in to change notification settings - Fork 2
도커빌드시 minio 패키지 설치 추가 #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @inoray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 풀 리퀘스트는 프로젝트의 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 Docker 빌드 시 minio 패키지를 설치하도록 의존성에 추가하는 변경 사항을 담고 있습니다. pyproject.toml에 minio를 추가한 것은 올바른 조치입니다. 다만, 빌드의 재현성을 높이기 위해 의존성 버전을 고정하는 것을 고려해볼 수 있습니다. 자세한 내용은 개별 코멘트를 참고해주세요.
genon/preprocessor/pyproject.toml
Outdated
| "opencv-python==4.11.0.86", | ||
| "numpy==2.3.4" | ||
| "numpy==2.3.4", | ||
| "minio>=7.2.20", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist: