Conversation
|
ping @gberaudo or @ger-benjamin :) Sorry I can't ask for reviews |
Co-authored-by: Stéphane Brunner <stephane.brunner@camptocamp.com>
|
hello, any updates? :) |
ger-benjamin
left a comment
There was a problem hiding this comment.
Sorry, I don't really have time for that currently :-/
It looks fine to me, but is it fine to NOT do anymore (was line 171):
feature = this.featureCircleAsPolygon(feature as Feature<Circle>);
And after that, still doing ?:
const origGeojsonFeature = this.geojsonFormat.writeFeatureObject(feature);
Also featureCircleAsPolygon is now unused, I think e can remove it (but it's protected, that means, that's a breaking change to remove it)
|
@ger-benjamin Fixed what you've mentioned and added a test for what was happening on geogirafe. Let me know if anything is missing or unclear |
| { | ||
| "name": "@geoblocks/mapfishprint", | ||
| "version": "0.2.22", | ||
| "version": "0.2.23", |
There was a problem hiding this comment.
@gberaudo a breaking change is a major version, right ? We shoule start to follow strict semver rules.
| "version": "0.2.23", | |
| "version": "1.0.0", |
I don't care to make a v1 on such bugfix. That's just a number.
This PR fixes an issue where a Circle was converted to a FeatureCollection and not printed at all.
You can reproduce the bug here:
These modifications allow to keep the original style of the circle and just convert the geometry