feat: drop support for PHP < 8.1, symfony < 6.4 (WIP) #368
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,9 +5,9 @@ | |
| backupGlobals="false" | ||
| backupStaticAttributes="false" | ||
| colors="true" | ||
| convertErrorsToExceptions="false" | ||
| convertNoticesToExceptions="false" | ||
| convertWarningsToExceptions="false" | ||
| processIsolation="false" | ||
| stopOnFailure="false" | ||
| bootstrap="tests/bootstrap.php" | ||
|
|
@@ -28,4 +28,5 @@ | |
| <listeners> | ||
| <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"/> | ||
| </listeners> | ||
|
|
||
| </phpunit> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,9 +23,6 @@ | |
| */ | ||
| class BazingaGeocoderBundle extends Bundle | ||
| { | ||
| public function build(ContainerBuilder $container): void | ||
| { | ||
| parent::build($container); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,7 +66,12 @@ public function testExecute(): void | |
| ->willReturn([]); | ||
|
|
||
| $app = new Application($kernel); | ||
|
|
||
| if (method_exists($app, 'addCommand')) { | ||
| $app->addCommand((new GeocodeCommand($geocoder))->setName('geocoder:geocode')); | ||
| } else { | ||
| $app->add((new GeocodeCommand($geocoder))->setName('geocoder:geocode')); | ||
| } | ||
|
|
||
| $command = $app->find('geocoder:geocode'); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,10 +52,6 @@ public function testInitBundle(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| }]); | ||
|
|
||
| $container = self::getContainer(); | ||
|
|
@@ -70,11 +66,6 @@ public function testBundleWithOneProviderConfiguration(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| $kernel->addTestConfig(__DIR__.'/config/simple.yml'); | ||
| }]); | ||
|
|
||
|
|
@@ -90,11 +81,6 @@ public function testBundleWithCachedProvider(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| $kernel->addTestConfig(__DIR__.'/config/cache.yml'); | ||
| }]); | ||
|
|
||
|
|
@@ -112,11 +98,6 @@ public function testCacheLifetimeCanBeNull(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| $kernel->addTestConfig(__DIR__.'/config/cache_without_lifetime.yml'); | ||
| }]); | ||
|
|
||
|
|
@@ -142,11 +123,6 @@ public function testBundleWithPluginsYml(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| $kernel->addTestConfig(__DIR__.'/config/service_plugin.yml'); | ||
| }]); | ||
|
|
||
|
|
@@ -164,10 +140,6 @@ public function testBundleHasRegisteredDumpers(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| }]); | ||
|
|
||
| $container = self::getContainer(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,7 +63,7 @@ protected static function createKernel(array $options = []): KernelInterface | |
| $kernel->addTestConfig(static function (ContainerBuilder $container) { | ||
| $container->prependExtensionConfig('doctrine', [ | ||
| 'orm' => [ | ||
| // 'report_fields_where_declared' => true, | ||
| ], | ||
| ]); | ||
|
|
||
|
|
@@ -95,13 +95,7 @@ public function testPersistForProperty(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| $kernel->addTestConfig(__DIR__.'/config/listener.yml'); | ||
| }]); | ||
|
|
||
| $container = self::getContainer(); | ||
|
|
@@ -173,13 +167,7 @@ public function testPersistForGetter(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| $kernel->addTestConfig(__DIR__.'/config/listener.yml'); | ||
| }]); | ||
|
|
||
| $container = self::getContainer(); | ||
|
|
@@ -251,13 +239,7 @@ public function testPersistForInvalidGetter(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| $kernel->addTestConfig(__DIR__.'/config/listener.yml'); | ||
| }]); | ||
|
|
||
| $container = self::getContainer(); | ||
|
|
@@ -281,13 +263,7 @@ public function testPersistForEmptyProperty(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| $kernel->addTestConfig(__DIR__.'/config/listener.yml'); | ||
| }]); | ||
|
|
||
| $container = self::getContainer(); | ||
|
|
@@ -311,13 +287,7 @@ public function testDoesNotGeocodeIfAddressNotChanged(): void | |
| { | ||
| self::bootKernel(['config' => static function (TestKernel $kernel) { | ||
| $kernel->addTestConfig(__DIR__.'/config/framework.yml'); | ||
| $kernel->addTestConfig(__DIR__.'/config/listener.yml'); | ||
| }]); | ||
|
|
||
| $container = self::getContainer(); | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this env var is deprecated, can you add
->setUnsupportedPhpVersionAllowed(true)tophp-cs-fixer.dist.php?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but can be done in a follow-up pr