Open
Conversation
Goal history cards were rendering every attempt inline, making the section very tall once goals accumulated multiple retries. Hide the per-goal timeline by default and add a Show/Hide attempts toggle on the summary row. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors “missed goal retry” and goal tracking to be attempt-based (parent goal + per-attempt rows), moves retry actions into task cards, and aligns recurring-task “missed” detection with a handled-occurrence model (where an achieved retry handles the originally missed occurrence).
Changes:
- Introduces
study_goal_attemptsand new goal lifecycle fields (status,abandoned_explicitly,achieved_attempt_id) with schema backfill/migration logic. - Updates UI panels (Planner / Calendar / Tasks / Profile) to display goal attempts, retries, and new grouping/toggle behaviors.
- Updates recurring missed-occurrence detection/badges to use “handled task-date pairs” derived from attempt chains.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/com/studysync/domain/service/StudyServicePersistenceTest.java | Adds persistence tests for attempt lifecycle, retries, and handled recurring occurrences. |
| src/main/resources/styles.css | Fixes ComboBox popup ListView sizing behavior. |
| src/main/resources/schema.sql | Adds study_goal_attempts, new goal lifecycle columns, indexes, and a non-destructive backfill. |
| src/main/java/com/studysync/presentation/ui/components/TaskManagementPanel.java | Moves planning/editing/retry/abandon actions into per-task goal history UI. |
| src/main/java/com/studysync/presentation/ui/components/StudyPlannerPanel.java | Adds Today/All Tasks view toggle, “Reason” grouping, attempt overview metrics, and per-task retry section. |
| src/main/java/com/studysync/presentation/ui/components/ProfileViewPanel.java | Replaces “Achieved Goals” section with a filterable/sortable goal attempt history view. |
| src/main/java/com/studysync/presentation/ui/components/CalendarViewPanel.java | Updates missed badges/counts to use handled-occurrence logic and renames goal UI strings to attempts. |
| src/main/java/com/studysync/presentation/ui/StudySyncUI.java | Wires StudyService into TaskManagementPanel and updates delayed-goal processing logs. |
| src/main/java/com/studysync/domain/service/TaskService.java | Switches recurring missed-occurrence checks to handled-occurrence API. |
| src/main/java/com/studysync/domain/service/StudyService.java | Implements attempt-based replanning and simplifies delayed processing to “mark overdue attempts missed”. |
| src/main/java/com/studysync/domain/entity/StudyGoal.java | Major refactor to attempt-view model, handled-occurrence queries, and attempt creation/achievement APIs. |
| scripts/install.sh | Improves install behavior by pruning old app jars and selecting newest jar for launcher. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
geokoko
force-pushed
the
feature/planner-task-retry-controls
branch
from
4fd9a8d to
93d7a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Notes