Use existing en.json i18n keys for guest policy notifications; resolve nested keys on frontend#7
Draft
Copilot wants to merge 8 commits intofix-pres-zoom-mapfrom
Draft
Conversation
Co-authored-by: germanocaumo <2726293+germanocaumo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing test by adding participantPermissionsTab element
Fix: Click participantPermissionsTab before lockEditSharedNotes in lock viewers tests
Mar 11, 2026
…ermissionsTab) Co-authored-by: germanocaumo <2726293+germanocaumo@users.noreply.github.com>
Copilot
AI
changed the title
Fix: Click participantPermissionsTab before lockEditSharedNotes in lock viewers tests
Fix Playwright tests for lock-viewers modal tab navigation
Mar 11, 2026
…oval, freeForAll) Co-authored-by: germanocaumo <2726293+germanocaumo@users.noreply.github.com>
Copilot
AI
changed the title
Fix Playwright tests for lock-viewers modal tab navigation
Fix Playwright tests for lock-viewers modal tab navigation + add presentation permission tests
Mar 11, 2026
…bcam step Co-authored-by: germanocaumo <2726293+germanocaumo@users.noreply.github.com>
Copilot
AI
changed the title
Fix Playwright tests for lock-viewers modal tab navigation + add presentation permission tests
Add Playwright tests for presentation permission tab options (moderatorOnly, requireApproval, freeForAll)
Mar 11, 2026
…on#24672) Co-authored-by: germanocaumo <2726293+germanocaumo@users.noreply.github.com>
Copilot
AI
changed the title
Add Playwright tests for presentation permission tab options (moderatorOnly, requireApproval, freeForAll)
Restore guest policy change notifications & remove redundant webcam lock from presenterPolicyModeratorOnly test
Mar 11, 2026
Co-authored-by: germanocaumo <2726293+germanocaumo@users.noreply.github.com>
Copilot
AI
changed the title
Restore guest policy change notifications & remove redundant webcam lock from presenterPolicyModeratorOnly test
Restore guest policy change notifications removed by #24672
Mar 12, 2026
… presentation permission tests Co-authored-by: germanocaumo <2726293+germanocaumo@users.noreply.github.com>
Copilot
AI
changed the title
Restore guest policy change notifications removed by #24672
Use existing en.json i18n keys for guest policy notifications; resolve nested keys on frontend
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guest policy change notification was hardcoding English strings in Akka (
"Ask moderator","Always accept", etc.) asmessageValues, making them untranslatable and duplicatingapp.guest-policy.button.*keys already inen.json.Changes
SetGuestPolicyMsgHdlr.scala: Pass the i18n key ("app.guest-policy.button.askModerator"etc.) asmessageValues["0"]instead of a hardcoded English label. UseOption[String]to eliminate the empty-string sentinel pattern.notifications/component.tsx: AdduseIntl()and aresolveMessageValueshelper — anymessageValuestarting with"app."is resolved viaintl.formatMessage({ id: v })before being passed to<FormattedMessage>, enabling full client-locale translation of nested i18n keys sent from the server.en.json: Add missing"app.guest-policy.button.alwaysAcceptAuth": "Always accept authenticated"key (used by theALWAYS_ACCEPT_AUTHpolicy type, previously had no corresponding entry).lockViewers.ts(tests): Improve all three presentation permission tests to also assert the correct toast notification fires:presenterPolicyModeratorOnly→ asserts "Presenter request is now disabled for viewers"presenterPolicyRequireApproval/presenterPolicyFreeForAll→ first setmoderatorOnlyto enter a state where switching away triggers the "Presenter request is now enabled for viewers" notification, then assert it appears✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.