Skip to content

Make ctx.db types match convex@1.31.2 #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nicolapps merged 1 commit into from
Dec 18, 2025
+32 −26
Merged

Make ctx.db types match convex@1.31.2 #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
"dependencies": {
"classnames": "^2.3.2",
"convex": "^1.31.0",
"convex": "^1.31.2",
"convex-helpers": "file:packages/convex-helpers/dist",
"hono": "^4.3.6",
"react": "^19.2.3",
Expand Down
6 changes: 6 additions & 0 deletions packages/convex-helpers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 0.1.109 (upcoming)

- Triggers/row-level security: fix a type issue with the `ctx.db` APIs with
table name arguments (see the changelog of
[`convex@1.31.2`](https://github.com/get-convex/convex-js/blob/main/CHANGELOG.md#1312))

## 0.1.108

- `makeUseQueryWithStatus`: fix handling of some argument values
Expand Down
20 changes: 10 additions & 10 deletions packages/convex-helpers/server/rowLevelSecurity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ class WrapReader<Ctx, DataModel extends GenericDataModel>
}

get<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
): Promise<DocumentByName<DataModel, TableName> | null>;
get<TableName extends TableNamesInDataModel<DataModel>>(
id: GenericId<TableName>,
Expand Down Expand Up @@ -356,8 +356,8 @@ class WrapWriter<Ctx, DataModel extends GenericDataModel>
}

patch<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
value: Partial<DocumentByName<DataModel, TableName>>,
): Promise<void>;
patch<TableName extends TableNamesInDataModel<DataModel>>(
Expand All @@ -374,8 +374,8 @@ class WrapWriter<Ctx, DataModel extends GenericDataModel>
}

replace<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
value: WithOptionalSystemFields<DocumentByName<DataModel, TableName>>,
): Promise<void>;
replace<TableName extends TableNamesInDataModel<DataModel>>(
Expand All @@ -392,8 +392,8 @@ class WrapWriter<Ctx, DataModel extends GenericDataModel>
}

delete<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
): Promise<void>;
delete(id: GenericId<TableNamesInDataModel<DataModel>>): Promise<void>;
async delete(arg0: any, arg1?: any): Promise<void> {
Expand All @@ -405,8 +405,8 @@ class WrapWriter<Ctx, DataModel extends GenericDataModel>
}

get<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
): Promise<DocumentByName<DataModel, TableName> | null>;
get<TableName extends TableNamesInDataModel<DataModel>>(
id: GenericId<TableName>,
Expand Down
28 changes: 14 additions & 14 deletions packages/convex-helpers/server/triggers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,17 +171,17 @@ export class DatabaseWriterWithTriggers<
}

delete<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
): Promise<void>;
delete(id: GenericId<TableNamesInDataModel<DataModel>>): Promise<void>;
delete(arg0: any, arg1?: any): Promise<void> {
return this.writer.delete(arg0, arg1);
}

get<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
): Promise<DocumentByName<DataModel, TableName> | null>;
get<TableName extends TableNamesInDataModel<DataModel>>(
id: GenericId<TableName>,
Expand All @@ -198,8 +198,8 @@ export class DatabaseWriterWithTriggers<
}

patch<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
value: PatchValue<DocumentByName<DataModel, TableName>>,
): Promise<void>;
patch<TableName extends TableNamesInDataModel<DataModel>>(
Expand All @@ -224,8 +224,8 @@ export class DatabaseWriterWithTriggers<
}

replace<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
value: WithOptionalSystemFields<DocumentByName<DataModel, TableName>>,
): Promise<void>;
replace<TableName extends TableNamesInDataModel<DataModel>>(
Expand All @@ -252,8 +252,8 @@ export function writerWithTriggers<
): GenericDatabaseWriter<DataModel> {
const patch: {
<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
value: PatchValue<DocumentByName<DataModel, TableName>>,
): Promise<void>;
<TableName extends TableNamesInDataModel<DataModel>>(
Expand Down Expand Up @@ -293,8 +293,8 @@ export function writerWithTriggers<

const replace: {
<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
value: WithOptionalSystemFields<DocumentByName<DataModel, TableName>>,
): Promise<void>;
<TableName extends TableNamesInDataModel<DataModel>>(
Expand Down Expand Up @@ -334,8 +334,8 @@ export function writerWithTriggers<

const delete_: {
<TableName extends TableNamesInDataModel<DataModel>>(
table: NonUnion<TableName>,
id: GenericId<TableName>,
table: TableName,
id: GenericId<NonUnion<TableName>>,
): Promise<void>;
(id: GenericId<TableNamesInDataModel<DataModel>>): Promise<void>;
} = async (arg0: any, arg1?: any) => {
Expand Down
Loading